Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arrays in [DefaultValue] attributes #1164

Merged
merged 1 commit into from
May 11, 2023
Merged

Add support for arrays in [DefaultValue] attributes #1164

merged 1 commit into from
May 11, 2023

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Feb 16, 2023

Fixes #1163

@0xced 0xced mentioned this pull request Mar 1, 2023
Merged
@FrankRay78
Copy link
Contributor

I plan to review both your PR's over the next week or two @0xced, apologies for the delay and thanks for the patience.

@FrankRay78 FrankRay78 self-requested a review May 10, 2023 13:07
@FrankRay78 FrankRay78 merged commit dac2097 into spectreconsole:main May 11, 2023
@FrankRay78
Copy link
Contributor

Thank you @0xced, another excellent contribution.

I particularly liked the following refactoring you did in HelpWriter:

image

@0xced 0xced deleted the DefaultValue-Array branch May 11, 2023 14:51
@0xced
Copy link
Contributor Author

0xced commented May 11, 2023

Yeah, that's exactly when switch expressions and pattern matching shines. 😀 And thanks for reviewing and merging once again!

Do you happen to know when preview versions (or even stable versions) of Spectre.Console are deployed to NuGet?

@FrankRay78
Copy link
Contributor

re: NuGet - I'll ask Patrick. It's been a while now since the 46 release.

@FrankRay78
Copy link
Contributor

@0xced I will prepare the release notes for 0.47 this week, and see about getting it deployed to NuGet shortly thereafter.

@0xced
Copy link
Contributor Author

0xced commented May 15, 2023

Awesome! 🥳

@FrankRay78
Copy link
Contributor

Here it is @0xced, in case you've muted notifications 😉 https://github.com/spectreconsole/spectre.console/releases/tag/0.47.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankRay78 FrankRay78 FrankRay78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The [DefaultValue] attribute does not support arrays
2 participants
@0xced @FrankRay78