Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates asciinema update #648

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

phil-scott-78
Copy link
Contributor

Updates to the newest asciienama player. While I was in here I went ahead and updated some JS dependencies that'll hopefully hush dependabot.

Updates playwright to latest version. This requires an update in how it is ran as part of the statiq build set up to ensure dependencies exist for the run.

Also brings misc packages up to date to fix vulnerabilities.
@phil-scott-78
Copy link
Contributor Author

I went ahead and updated the CI scripts to use node v16, the current LTS, so I didn't accidently update the package.json lock file to v2 again and break the build

@phil-scott-78
Copy link
Contributor Author

opps, and it looks like playwright now also need .net core 5 installed. hmmm. i'll mess with it in a bit

Playwright CLI currently needs net5 to execute. There is a PR in the works to get it running on net6 but until then the recommended steps it to have both installed.
Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patriksvensson patriksvensson merged commit 461348f into spectreconsole:main Dec 1, 2021
@phil-scott-78 phil-scott-78 deleted the asciinema-update branch February 15, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants