Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 0.43.0 #663

Merged

Conversation

patriksvensson
Copy link
Contributor

No description provided.

@phil-scott-78
Copy link
Contributor

I've read through it and it looks good.

I'm gonna take a look at why playwright suddenly isn't working later today though

@phil-scott-78
Copy link
Contributor

Opps, looks like commit 8ce40ba might be the cause. I'm thinking that the change went from an explicit install to a restore, but without a tool-manifest it doesn't know to install playwright hence the error.

@patriksvensson
Copy link
Contributor Author

@phil-scott-78 Ah, I see. I had to remove it since it errored when installing since it was specified in the manifest. Any suggestions on how to move forward here?

@phil-scott-78
Copy link
Contributor

phil-scott-78 commented Dec 16, 2021

I'm thinking dotnet tool saw the dotnet-tools.json in the root of the repository and put the entry for microsoft.playwright.cli there. But we are running these commands from a child folder. So, when we are restoring from the docs folder perhaps it isn't finding it? I'm on my phone so I can test, but perhaps a dotnet-tools.json file in the docs folder is needed with playwright installed there?

@phil-scott-78
Copy link
Contributor

I think I got the build fixed with #667. After that's reviewed and (possibly) merged think we could rebase? Content looks good, just gotta make sure it gets deployed :-)

@phil-scott-78 phil-scott-78 merged commit 1dbaf50 into spectreconsole:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants