Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #688 (Invalid WithExample call on the CommandApp doc page) #689

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

jouniheikniemi
Copy link
Contributor

@jouniheikniemi jouniheikniemi commented Jan 13, 2022

Fixes #688

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nils-a nils-a merged commit 0b988ff into spectreconsole:main Jan 13, 2022
@nils-a
Copy link
Contributor

nils-a commented Jan 13, 2022

@jouniheikniemi your changes have been merged, thanks for your contribution 👍

@jouniheikniemi jouniheikniemi deleted the commandapp-example-fix branch January 13, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CommandApp doc page has an erroneous WithExample statement
4 participants