Simplify exception formatting #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Now that exceptions are not _parsed_ anymore (spectreconsole#513 and spectreconsole#637), keeping the `ExceptionInfo` and `StackFrameInfo` internal classes doesn't make much sense anymore. The `Exception` and `StackFrame` types can be used by the `ExceptionFormatter` class directly, without conversion.
0xced
force-pushed
the
simplify-exception-formatting
branch
from
3f62b11
to
f86e9fe
Compare
phil-scott-78
approved these changes
Feb 3, 2022
This was referenced Mar 27, 2022
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that exceptions are not parsed anymore (#513 and #637), keeping the
ExceptionInfoandStackFrameInfointernal classes doesn't make much sense anymore. TheExceptionandStackFrametypes can be used by theExceptionFormatterclass directly, without conversion.