Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better type names for return types and parameters #719

Conversation

phil-scott-78
Copy link
Contributor

Uses the typenamehelper from Ben.Demystifer to help break down things like generic lists into their actual type display name for return types of methods and their paramters.

Before

image

After

image

Uses the typenamehelper from Ben.Demystifer to help break down things like generic lists into their actual type display name.
@phil-scott-78
Copy link
Contributor Author

Added some code to break down params that are tuples.

If someone really wanted to get after it, constructors, lambdas and local functions are in Ben.Demystify but the code for grabbing those is a bit more complex than looking at the types. But for this PR I think it's complete and ready for review.

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@patriksvensson patriksvensson merged commit 74a2e10 into spectreconsole:main Feb 4, 2022
@phil-scott-78 phil-scott-78 deleted the better-typenames-in-exceptions branch February 15, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants