Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for TextPath widget #757

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Add documentation for TextPath widget #757

merged 1 commit into from
Mar 1, 2022

Conversation

patriksvensson
Copy link
Contributor

No description provided.

@patriksvensson patriksvensson marked this pull request as draft February 27, 2022 14:33
@patriksvensson patriksvensson marked this pull request as ready for review February 27, 2022 15:09
@nils-a
Copy link
Contributor

nils-a commented Mar 1, 2022

LGTM in general. However, the change from StemStyle(Color) to StemColor(Color) and LeafStyle(Color) to LeafColor(Color) is missing in the example (hence, the failed build).

@patriksvensson
Copy link
Contributor Author

Will fix

@patriksvensson
Copy link
Contributor Author

@nils-a Updated

nils-a
nils-a approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nils-a nils-a merged commit fbe1d0b into spectreconsole:main Mar 1, 2022
@nils-a nils-a linked an issue Mar 1, 2022 that may be closed by this pull request
Add documentation for TextPath widget #756
Closed
@nils-a nils-a mentioned this pull request Mar 1, 2022
Closed
This was referenced Mar 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Apr 3, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Apr 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-a nils-a nils-a approved these changes

@phil-scott-78 phil-scott-78 Awaiting requested review from phil-scott-78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for TextPath widget
2 participants
@patriksvensson @nils-a