Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress for Cluster Groups #1089

Merged
merged 9 commits into from
Feb 3, 2023
Merged

Ingress for Cluster Groups #1089

merged 9 commits into from
Feb 3, 2023

Conversation

ritawatson
Copy link
Contributor

@ritawatson ritawatson commented Jan 18, 2023 •
edited by karl-cardenas-coding
Loading

This PR documents steps to add Ingress to a Cluster Group.

Jira: https://spectrocloud.atlassian.net/browse/PPD-944

Preview.

@ritawatson ritawatson added documentation Improvements or additions to documentation size/L labels Jan 18, 2023
@ritawatson ritawatson requested review from TylerGillson and a team January 18, 2023 23:23
@spectro-prow spectro-prow added the do-not-merge/work-in-progress Work in-progress. DO NOT MERGE label Jan 18, 2023
@netlify
Copy link

netlify bot commented Jan 18, 2023 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit b863f04
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/63dd5482ef5a000008a21082
😎 Deploy Preview https://deploy-preview-1089--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ritawatson ritawatson marked this pull request as ready for review January 18, 2023 23:26
@spectro-prow spectro-prow removed the do-not-merge/work-in-progress Work in-progress. DO NOT MERGE label Jan 18, 2023
@karl-cardenas-coding
Copy link
Contributor

/retest

karl-cardenas-coding
karl-cardenas-coding requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the steps are great, we just need to surface some information that is missing.

content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jan 23, 2023
View reviewed changes
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md
```
kubectl get namespaces
```
This should display a list of namespaces as shown in the example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'namespaces'?

@TylerGillson TylerGillson self-requested a review January 24, 2023 01:02
karl-cardenas-coding
karl-cardenas-coding approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ritawatson . I just have some minor suggestions that need to be addressed.

content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Show resolved Hide resolved
content/docs/04.5-devx/03-cluster-groups/35-ingress-cluster-group.md Outdated Show resolved Hide resolved
@ritawatson ritawatson marked this pull request as draft January 25, 2023 00:35
@TylerGillson TylerGillson self-requested a review January 25, 2023 01:02
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karl-cardenas-coding, ritawatson, tiwarisumit3, TylerGillson
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ritawatson ritawatson marked this pull request as ready for review February 3, 2023 18:56
@ritawatson ritawatson merged commit f1d48db into master Feb 3, 2023
@ritawatson ritawatson deleted the ingress-for-cluster-group branch February 3, 2023 19:01
karl-cardenas-coding pushed a commit that referenced this pull request Mar 13, 2023
@ritawatson
Ingress for Cluster Groups (#1089)
f5db4fb 
* Ingress for Cluster Groups

* Incorporates comments

* Changed tenant level to scope

* Fix spacing in substeps

* Revised 3rd bullet

* Added final comments

* Removed SSL example

* Final changes with link to Prereqs

* Change nginx-ingress name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@TylerGillson TylerGillson TylerGillson approved these changes

@tiwarisumit3 tiwarisumit3 tiwarisumit3 approved these changes

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ritawatson @karl-cardenas-coding @spectro-prow @TylerGillson @tiwarisumit3