Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release 3.4 #1229

Merged
merged 51 commits into from
May 23, 2023
Merged

feat: release 3.4 #1229

merged 51 commits into from
May 23, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Apr 4, 2023

Describe the Change

This PR contains documentation content related to 3.4

Review Changes

💻 Preview

@karl-cardenas-coding karl-cardenas-coding added the 3.4 3.4 Release label Apr 4, 2023
@spectro-prow spectro-prow added do-not-merge/work-in-progress Work in-progress. DO NOT MERGE size/XS labels Apr 4, 2023
@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 71d5966
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/646c637cbbdeab00088a6619
😎 Deploy Preview https://deploy-preview-1229--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

* docs: updated language that lists the available Palette platforms PDE can be used

* docs: added Palette version PPD-1171
* add kube-api audit logging how-to

* update docs with use-cases

* docs: added a folder and intro paragraph

* docs: fixed missing infobox element

* docs: rafactored to fit how-to layout and style guide

* docs: removed parameter table

* fixed symbol leak

* Update 10-create-manage-vm.md (#1248)

small change

* Update 15-vm-roles-permissions.md (#1247)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* docs: updated guide with missing content

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: antongisli <anton@spectrocloud.com>
karl-cardenas-coding and others added 2 commits April 24, 2023 07:09
* Update 10-create-manage-vm.md (#1248)

small change

* Update 15-vm-roles-permissions.md (#1247)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Palette self-hosted airgap refactor (#1230)

* docs: updated intro and reqs

* docs: updated install steps for Airgap DOC-745

* save

* docs: updated install steps for Airgap DOC-745

* docs: added validation steps

* docs: added validation steps

* docs: added a diagram to improve the airgap steps

* docs: updated instructions for validation

* docs: improve validation steps

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Optimised images with calibre/image-actions

* Apply suggestions from code review

* docs: updated image

* Optimised images with calibre/image-actions

* docs: added feedback from Zulfi

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* docs: Prometheus Cluster Metrics (#1239)

* docs: started documenting the Palette metrics steps

* docs: added steps for metrics pack in host agent guide PEM-1523

* docs: added image of cluster metrics pack

* docs: added packs page for Prometheus cluster metrics

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Optimised images with calibre/image-actions

* docs: fixed URLs

* Update content/docs/04-clusters/06-cluster-management/01.9-monitoring/20-deploy-agent.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* updating aws trust policies

* docs: PCP-1071 updated styling and minor lanaguage addition

---------

Co-authored-by: antongisli <anton@spectrocloud.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
karl-cardenas-coding and others added 8 commits April 25, 2023 08:05
* docs: doc-755 added public IP addresses

* Update content/docs/02.5-architecture/04.5-palette-public-ips.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
* WIP DOC-725 Nested API Tree

* Filtered + Mapped Original Titles over the JSON object

* Small fix

* Deleted unnecessary files

* Added line on Folders

* Small fix

* Helm Chart Install Reference (#1241)

* DOC-751_v3.4

* DOC-751_v3.4

* DOC-751_v3.4

* doc_751_draft_changes

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/Helm Chart Install References

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* DOC_751_Reviewed_Changes_1

* DOC_751_Changes

* DOC_751_Review_Changes_2

* DOC_751_review_changes

* DOC_751_review_changes_3

* Doc_751_with_added_images

* DOC_751_review_changes_5

* DOC_751_review_changes_6

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* DOC_751_Review_changes_7

* Doc_751_review_9

* DOC_751_Review_Changes_10_Proofread_Complete

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/12-enterprise-version/03.5-helm-chart-install-reference.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* DOC_751_review_changes

* Docs_751_review_changes_11

* DOC_751_review_changes_12

* DOC_751_Review_changes_13

* DOC_751_Review_Changes_14

* DOC_751_Review_changes_15

* DOC_751

* DOC_751_review_changes_16

* Doc_751_edits

* DOC_751_edits

* DOC_751_edits

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* DOC_751

* Doc_751_reviewd_changes_19

* DOC_751_reviewed_changes_20

---------

Co-authored-by: Rahul Hazra <rahulhazra@Rahuls-MacBook-Pro.local>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* DOC-725 Improve SideBar Behavior [docs && api]

* Update 16-spectro-downloads.md (#1259)

* improvements for main sidebar

* docs: fixed Helm chart variable name (#1260)

* Update 03-prepare-user-data.md (#1261)

* Update 03-prepare-user-data.md

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* minor style update

* style improvements

---------

Co-authored-by: Mircea Bozianu <mircea@spectrocloud.com.com>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rahul Hazra <126905240+rahulhazra97@users.noreply.github.com>
Co-authored-by: Rahul Hazra <rahulhazra@Rahuls-MacBook-Pro.local>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: Alex Leleu <alex.leleu@nops.io>
Co-authored-by: Rishi Anand <rishi@spectrocloud.com>
* docs: added MaaS image

* Update content/docs/04-clusters/02-data-center/01-maas/05-install-manage-maas-pcg.md

Co-authored-by: Rahul Hazra <126905240+rahulhazra97@users.noreply.github.com>

---------

Co-authored-by: Rahul Hazra <126905240+rahulhazra97@users.noreply.github.com>
* docs: updated vale rule

* Cloudanix (#1274)

* Added integration document for cloudanix

* Added logo

* Logo url added

* Removed mention of falco and Notable Parameters

* Removed mention of falco and Notable Parameters

* Minor typo and grammar corrected

* cloudanix documentation updated

* k8s version updated to 1.19

* Revised resource limits and added misconfig-cron

* PR related changes as suggested byt Rita

* PR related changes as suggested byt Rita

* Added examples for threats and unusual events

* Added description, parameters, reference and minor changes

* Minor change in description of misconfig-cron

* Added kubernetes from 1.19 to 1.24

* Added kubernetes version from 1.19.x to 1.24.x and included changes made by spectroclould

* Update 00-cloudanix.md

* Added support documentation for kubernetes 1.25 and higher

* Added entire labels yaml

* Added enitre labels yaml

* Added steps to create a labels pack

* Minor PR comment changes

---------

Co-authored-by: Purusottam <mpurusottamc@gmail.com>
Co-authored-by: ajinkyajawalkar <ajinkya@cloudanix.com>

* Move install steps to Usage section

* Format added info in 1.0.x tab only

* Update content/docs/06-integrations/00-cloudanix.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Update content/docs/06-integrations/00-cloudanix.md

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>

* Add review comments

---------

Co-authored-by: Ajinkya Jawalkar <63242389+ajinkya1986@users.noreply.github.com>
Co-authored-by: Purusottam <mpurusottamc@gmail.com>
Co-authored-by: ajinkyajawalkar <ajinkya@cloudanix.com>
Co-authored-by: Rita Watson <rita@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
karl-cardenas-coding and others added 4 commits May 18, 2023 17:02
* PCP_1146_BYOOS_Edge

* PCP1146_EdgeBYOOS

* PCP-1146_edge_byoos

* PCP-1146_Build_images

* PCP_1126_build_image

* 1146_BYOS_(minor)

* 1146_build_images(minor)

* PCP_1146_model_profile

* pcp_1146_model_profile

* pcp_1146_model_profiles

* pcp_1146_model_profiles

* pcp_1146_model_profile

* pcp_1145_packs_page

* pcp_1145_byoos_packs

* 1145_byoos_packs

* Update content/docs/04-clusters/03-edge/04-edgeforge-workflow/01-build-kairos-os.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/04-edgeforge-workflow/01-build-kairos-os.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/04-edgeforge-workflow/01-build-kairos-os.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/04-edgeforge-workflow/01-build-kairos-os.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/04-edgeforge-workflow/04-build-images.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/06-integrations/00-byoos.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/06-integrations/00-byoos.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/06-integrations/00-byoos.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/06-integrations/00-byoos.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/09-site-deployment/01-model-profile.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/06-integrations/00-byoos.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/06-integrations/00-byoos.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/06-integrations/00-byoos.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* pcp_1146_build

* Paramters

* pcp_1145_infobox_removed

* pcp_1145_double_space

* pcp_1146

* pcp_1145_packs

* pcp_1145_packs

* pcp_1145

* pcp_1145_packs

* chore: minor updates

* pcp_1146_insert_tabs

* pcp_1145_tabs

* chore: minor updates

* chore: minor updates

* chore: minor updates

* pcp_1145

* pcp_1145

* pcp_1145_packs

* pcp_1145_packs_non_edge_usage

* pcp_1145_prepare_user_data_apply_proxy_codefix

* pcp_1145_packs_usage_edge

* pcp_1145_

* pcp_1145

* pcp_1145

* PE_1513_Device_config_edit

* docs: updated BYOOS with language fixes and content

* Optimised images with calibre/image-actions

* docs: updated BYOOS with language fixes and content

* Update content/docs/04-clusters/03-edge/04-edgeforge-workflow.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Update content/docs/04-clusters/03-edge/04-edgeforge-workflow/01-build-kairos-os.md

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Optimised images with calibre/image-actions

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

---------

Co-authored-by: Rahul Hazra <rahulhazra@Rahuls-MacBook-Pro.local>
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* docs: updated download URLs

* docs: updated CLIs and release notes

* docs: updated compatibility page

* docs: updated Palette CLI install steps
@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review May 19, 2023 19:42
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner May 19, 2023 19:42
@spectro-prow spectro-prow removed the do-not-merge/work-in-progress Work in-progress. DO NOT MERGE label May 19, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

content/docs/00-release-notes.md|219 col 11| [Vale.Spelling] Did you really mean 'Upgrader'?
content/docs/00-release-notes.md|223 col 3| [Vale.Spelling] Did you really mean 'Reloader'?
content/docs/00-release-notes.md|268 col 217| [Vale.Spelling] Did you really mean 'preloading'?
content/docs/04.5-devx.md|35 col 3| [Vale.Spelling] Did you really mean 'Airgap'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|191 col 28| [Vale.Terms] Use 'We' instead of 'we'.
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|274 col 118| [Vale.Terms] Use 'readme' instead of 'README'.
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|284 col 221| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|297 col 99| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|304 col 113| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|304 col 222| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|308 col 45| [Vale.Spelling] Did you really mean 'ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|312 col 209| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|324 col 37| [Vale.Spelling] Did you really mean 'Ngrok's'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|324 col 128| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|334 col 47| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|369 col 17| [Vale.Terms] Use 'Spectro' instead of 'spectro'.
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|388 col 232| [Vale.Terms] Use 'We' instead of 'we'.
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|388 col 356| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|413 col 60| [Vale.Terms] Use 'Spectro' instead of 'spectro'.
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|566 col 286| [Vale.Spelling] Did you really mean 'ARNs'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|566 col 365| [Vale.Terms] Use 'We' instead of 'we'.
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|908 col 90| [Vale.Spelling] Did you really mean 'Ngrok'?
content/docs/18-knowledgebase/01-tutorials/4.5-deploy-pack.md|927 col 39| [Vale.Terms] Use 'We' instead of 'we'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|102 col 111| [write-good.ThereIs] Don't start a sentence with 'There are'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|214 col 3| [Vale.Spelling] Did you really mean 'aws'?
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|385 col 39| [Vale.Terms] Use 'GCP' instead of 'gcp'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|417 col 10| [Vale.Terms] Use 'GCP' instead of 'gcp'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|420 col 7| [Vale.Terms] Use 'GCP' instead of 'gcp'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|427 col 3| [Vale.Terms] Use 'GCP' instead of 'gcp'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|520 col 3| [Vale.Terms] Use 'GCP' instead of 'gcp'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|545 col 101| [Vale.Terms] Use 'We' instead of 'we'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|696 col 235| [write-good.ThereIs] Don't start a sentence with 'There are'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|698 col 49| [Vale.Terms] Use 'We' instead of 'we'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|1045 col 54| [Vale.Terms] Use 'We' instead of 'we'.
content/docs/18-knowledgebase/01-tutorials/80-deploy-k8s-cluster.md|1139 col 101| [Vale.Terms] Use 'We' instead of 'we'.

github-actions[bot]

This comment was marked as duplicate.

Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spectrocloud spectrocloud deleted a comment from spectro-prow May 19, 2023
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karl-cardenas-coding, ritawatson
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karl-cardenas-coding and others added 2 commits May 21, 2023 07:44
* docs: added upgrade notes DOC-773

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 42.9%, saving 125.38 KB.

Filename Before After Improvement Visual comparison
assets/docs/images/clusters_edge_cloud-init_cloud-init-stages-supported.png 292.46 KB 167.08 KB -42.9% View diff

336 images did not require optimisation.

@sudkul87 sudkul87 merged commit e2bf1cb into master May 23, 2023
11 checks passed
@sudkul87 sudkul87 deleted the release-3-4 branch May 23, 2023 07:11
github-actions bot pushed a commit that referenced this pull request May 23, 2023
# [3.4.0](v3.3.0...v3.4.0) (2023-05-23)

### Bug Fixes

* package.json & package-lock.json to reduce vulnerabilities ([#1282](#1282)) ([b20c684](b20c684))
* upgrade antd from 4.24.8 to 4.24.9 ([#1290](#1290)) ([d5f9771](d5f9771))
* upgrade react-instantsearch-dom from 6.39.0 to 6.39.1 ([#1238](#1238)) ([678b82b](678b82b))
* upgrade sharp from 0.30.5 to 0.32.0 ([#1243](#1243)) ([7167c1b](7167c1b))

### Features

* release 3.4 ([#1229](#1229)) ([e2bf1cb](e2bf1cb)), closes [#1246](#1246) [#906](#906) [#1248](#1248) [#1247](#1247)
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.4 3.4 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants