Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added missing condition for non-cron workflows #1720

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

Describe the Change

This PR fixes a missing condition flag. WIthout the modification, the CI steps for building the website could occur in parallel.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 labels Oct 27, 2023
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner October 27, 2023 20:05
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 6704639
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/653c1bf66daa190008c9e751
😎 Deploy Preview https://deploy-preview-1720--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding merged commit 4b7f3b0 into master Oct 27, 2023
8 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the minor-ci-modification branch October 27, 2023 20:40
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 All backports failed

Status Branch Result
version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- ci: changed default workflow
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- ci: changed default workflow
- chore: released docs versioning
- docs: palette-cli URL update
version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- ci: changed default workflow

Manual backport

To create the backport manually run:

backport --pr 1720

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Oct 27, 2023
* ci: added missing condition for non-cron workflows

* ci: added slack notification
karl-cardenas-coding added a commit that referenced this pull request Oct 27, 2023
* ci: added missing condition for non-cron workflows

* ci: added slack notification
karl-cardenas-coding added a commit that referenced this pull request Oct 27, 2023
* ci: added missing condition for non-cron workflows

* ci: added slack notification
@karl-cardenas-coding
Copy link
Contributor Author

Backports adds manually to the version branches ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants