Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more context about IAM policies for AWS #1763

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Nov 8, 2023

Describe the Change

This PR carries over the work from #1419 . Changes include language cleanup and removing draft notes.

Review Changes

💻 Preview URL

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 8b0e42d
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/654bf2770ea4b300081f5d23
😎 Deploy Preview https://deploy-preview-1763--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 labels Nov 8, 2023
Copy link
Contributor

@ritawatson ritawatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the doc. Just one deletion to make for a repeating sentence. Otherwise LGTM.

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
@karl-cardenas-coding karl-cardenas-coding merged commit d772aab into master Nov 8, 2023
8 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the aws-policy-docs branch November 8, 2023 21:27
@karl-cardenas-coding karl-cardenas-coding added the auto-backport Enable backport label Nov 8, 2023
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 8, 2023
* docs: more context about IAM policies for AWS

* docs: updated IAM permissions document

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* docs: merge master

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
(cherry picked from commit d772aab)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 8, 2023
* docs: more context about IAM policies for AWS

* docs: updated IAM permissions document

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* docs: merge master

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
(cherry picked from commit d772aab)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- EKS user journey (#1715)
- docs: updated URLs to use file path context
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 1763

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Nov 8, 2023
* docs: more context about IAM policies for AWS

* docs: updated IAM permissions document

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* docs: merge master

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
karl-cardenas-coding added a commit that referenced this pull request Nov 8, 2023
* docs: more context about IAM policies for AWS

* docs: updated IAM permissions document

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* docs: merge master

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
(cherry picked from commit d772aab)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Nov 8, 2023
* docs: more context about IAM policies for AWS

* docs: updated IAM permissions document

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* docs: merge master

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
(cherry picked from commit d772aab)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Nov 8, 2023
* chore: updated version label

* docs: more context about IAM policies for AWS (#1763)

* docs: more context about IAM policies for AWS

* docs: updated IAM permissions document

* Apply suggestions from code review

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

* docs: merge master

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>

---------

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants