Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor clarification for node affinity #1774

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Minor clarification for node affinity #1774

merged 2 commits into from
Nov 9, 2023

Conversation

cloudmaniac
Copy link
Contributor

Describe the Change

Node affinity is only meant for vSphere target clusters, adding the clarification in release notes.

@cloudmaniac cloudmaniac requested a review from a team as a code owner November 9, 2023 14:35
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 17cca79
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/654cf04b668e8d00083cdb53
😎 Deploy Preview https://deploy-preview-1774--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding added auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 labels Nov 9, 2023
karl-cardenas-coding
karl-cardenas-coding approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cloudmaniac

@karl-cardenas-coding karl-cardenas-coding merged commit e3b0401 into master Nov 9, 2023
8 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the 4.1-rn-nodeaffinity-clarification branch November 9, 2023 14:56
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 9, 2023
@cloudmaniac
docs: minor clarification for node affinity (#1774)
3128ba7 
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit e3b0401)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Nov 9, 2023
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding pushed a commit that referenced this pull request Nov 9, 2023
@vault-token-factory-spectrocloud @cloudmaniac
docs: minor clarification for node affinity (#1774) (#1778)
28fad0b 
Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
(cherry picked from commit e3b0401)

Co-authored-by: Romain Decker <deckerromain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-cardenas-coding karl-cardenas-coding karl-cardenas-coding approved these changes

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

@caroldelwing caroldelwing Awaiting requested review from caroldelwing caroldelwing is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-4-1 Backport change to version 4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cloudmaniac @karl-cardenas-coding