Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image signature final #1909

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Image signature final #1909

merged 9 commits into from
Dec 18, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Dec 16, 2023

Describe the Change

This PR adds documentation and a cryptographic signing process for the offline documentation container.

Review Changes

💻 Preview URL

🎫 DOC-961

Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit d5730d8
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/657f254549ae8c0008ed2953
😎 Deploy Preview https://deploy-preview-1909--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding added documentation Improvements or additions to documentation enhancement New feature or request CI/CD CI/CD related changes backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 labels Dec 17, 2023
@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review December 17, 2023 16:07
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner December 17, 2023 16:07
Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! 🚀

Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@karl-cardenas-coding karl-cardenas-coding merged commit cbe5746 into master Dec 18, 2023
8 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the image-signature-final branch December 18, 2023 13:38
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Dec 18, 2023
* ci: added signing to Docke image

* ci: verify new vars

* ci: adding missing step ID

* ci: fixed pruning logic

* docs: updated the offline docs

* docs: warning added

* docs: langauge cleanup

* docs: vale feedback

* chore: typo correction

(cherry picked from commit cbe5746)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Dec 18, 2023
* ci: added signing to Docke image

* ci: verify new vars

* ci: adding missing step ID

* ci: fixed pruning logic

* docs: updated the offline docs

* docs: warning added

* docs: langauge cleanup

* docs: vale feedback

* chore: typo correction

(cherry picked from commit cbe5746)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- add missing doc subsection (#1903)
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 1909

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Dec 18, 2023
* ci: added signing to Docke image

* ci: verify new vars

* ci: adding missing step ID

* ci: fixed pruning logic

* docs: updated the offline docs

* docs: warning added

* docs: langauge cleanup

* docs: vale feedback

* chore: typo correction

(cherry picked from commit cbe5746)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Dec 18, 2023
* ci: added signing to Docke image

* ci: verify new vars

* ci: adding missing step ID

* ci: fixed pruning logic

* docs: updated the offline docs

* docs: warning added

* docs: langauge cleanup

* docs: vale feedback

* chore: typo correction

(cherry picked from commit cbe5746)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
@karl-cardenas-coding
Copy link
Contributor Author

The 3-4 label was incorrectly added by me. I forgot we didn't have a vertex section in 3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 CI/CD CI/CD related changes documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants