ci: support local docker development for arm64 #953
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for local development with Docker for Arm architecture based workstations. The current Makefile logic copies over the users
node_modules/
. Copying the node modules folder generates an issue with the dependencies Sharp. The workaround is to issue annpm install
from inside the container during the build..dockerignore
fileentry.sh
scriptThe Makefile also had the following updates:
npm ci
vsnpm install
. This removes the situation where a contributor updates thepackage-lock.json
when not intending to.