Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support local docker development for arm64 #953

Closed
wants to merge 4 commits into from

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Oct 27, 2022

This PR adds support for local development with Docker for Arm architecture based workstations. The current Makefile logic copies over the users node_modules/. Copying the node modules folder generates an issue with the dependencies Sharp. The workaround is to issue an npm install from inside the container during the build.

  • Added a .dockerignore file
  • Updated README with logo, overview section, and Docker local development steps.
  • Updated entry.sh script

The Makefile also had the following updates:

  • initialize now does an npm ci vs npm install. This removes the situation where a contributor updates the package-lock.json when not intending to.
  • Unused make commands are removed
  • Split out the docker build step from the docker-start command

CleanShot 2022-10-28 at 08 29 07

@spectro-prow spectro-prow added the do-not-merge/work-in-progress Work in-progress. DO NOT MERGE label Oct 27, 2022
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karl-cardenas-coding
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spectro-prow
Copy link

Hi @karl-cardenas-coding. Thanks for your PR.

I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review October 28, 2022 15:41
@spectro-prow spectro-prow removed the do-not-merge/work-in-progress Work in-progress. DO NOT MERGE label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants