feature: add the ability to associate a registration to a user #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinW520
commented
Dec 16, 2019
| @@ -2,6 +2,7 @@ | |||
| = simple_form_for([@event, @registration], validate: true) do |f| | |||
| = f.input :started_at, as: :hidden, input_html: { value: @registration.started_at } | |||
| = f.input :step_to_validate, as: :hidden, input_html: { value: "start" } | |||
| = f.input, :user_id, as: :hidden, input_html: { value: current_user.try(:id) } | |||
There was a problem hiding this comment.
@willblake01 -- this is importat. I suggest doing some reading on how try works
ColinW520
commented
Dec 16, 2019
| @@ -9,6 +9,7 @@ class Registration < ApplicationRecord | |||
|
|
|||
| belongs_to :event | |||
| belongs_to :discount_code, counter_cache: true, optional: true | |||
| belongs_to :user, optional: true | |||
There was a problem hiding this comment.
@willblake01 -- this is important. I recommend doing some googling on why the optional param is necessary here.
willblake01
approved these changes
Dec 16, 2019
| @@ -2,6 +2,7 @@ | |||
| = simple_form_for([@event, @registration], validate: true) do |f| | |||
| = f.input :started_at, as: :hidden, input_html: { value: @registration.started_at } | |||
| = f.input :step_to_validate, as: :hidden, input_html: { value: "start" } | |||
| = f.input, :user_id, as: :hidden, input_html: { value: current_user.try(:id) } | |||
| @@ -9,6 +9,7 @@ class Registration < ApplicationRecord | |||
|
|
|||
| belongs_to :event | |||
| belongs_to :discount_code, counter_cache: true, optional: true | |||
| belongs_to :user, optional: true | |||
willblake01
requested changes
Dec 16, 2019
Great catch! I will get that change made. |
ColinW520
force-pushed
the
feature/associate-users-to-registrations
branch
from
d4f927a
to
7cf2cc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registrations, in this system, serve as a data container pertinent to the individual registrant. Given the importance of the fact that each individual registrant must SIGN THEIR OWN WAIVER, we can use the registration class to be the association with the individual user (member, in this parlance), in pursuit of a user profile experience.
The current registration experience DOES NOT support the creation of accounts. This PR introduces the bare minimum of the functionality needed to support that.
To test:
^ everything should work, and the user_id value should be set on your registration