Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong file loading by separate_file function #1351

Open
Ir0098 opened this issue Apr 1, 2022 · 1 comment · May be fixed by #2476
Open

wrong file loading by separate_file function #1351

Ir0098 opened this issue Apr 1, 2022 · 1 comment · May be fixed by #2476
Labels
bug Something isn't working

Comments

@Ir0098
Copy link

Ir0098 commented Apr 1, 2022

The function separate_file employs fetch function to fetch files in a given path (i.e., savedir). The current version is okay unless sperate_file tries to fetch the new filename that already exists in savedir. This is already addressed by overwrite in the fetch; however, this can not be controlled within separate_file; then, please provide an access to overwrite within seperate_file:


def separate_file(self, path, savedir=".", overwrite=False):
...
path = fetch(fl, source=source, savedir=savedir, overwrite)


This problem becomes challenging in case of a huge dataset having plenty of similar filenames stored at different directories; then the user can simply set overwrite = True to avoid such a serious problem.

Thanks,

@anautsch anautsch added this to To do in Speech Separation via automation Apr 21, 2022
@anautsch
Copy link
Collaborator

anautsch commented Dec 7, 2022

relates to the #1303 complex

A suitable PR on this would be neat.

@asumagic asumagic linked a pull request Jul 19, 2024 that will close this issue
13 tasks
@asumagic asumagic added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants