Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Implementation of CumulativeLayerNorm #1772

Open
YoshikiMas opened this issue Dec 20, 2022 · 2 comments
Open

[Bug]: Implementation of CumulativeLayerNorm #1772

YoshikiMas opened this issue Dec 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@YoshikiMas
Copy link

Describe the bug

The implementation of CumulativeLayerNorm seems to be channel (or time-frame)-wise normalization instead of accumulating the information on past frames.

Expected behaviour

"ChannelwiseLayerNorm (cLN)" as in ESPnet might be more accurate name.

To Reproduce

No response

Versions

No response

Relevant log output

No response

Additional context

No response
@YoshikiMas YoshikiMas added the bug Something isn't working label Dec 20, 2022
@Adel-Moumen
Copy link
Collaborator

Maybe this is sufficient to just add it in the documentation.

Could you please make a PR with the change? Many thanks! :-)

@Adel-Moumen
Copy link
Collaborator

Hey, any news concerning this issue please ? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YoshikiMas @Adel-Moumen