Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have all log traces in compaction job report the cf name and job id #494

Closed
udi-speedb opened this issue May 4, 2023 · 2 comments · Fixed by #511
Closed

Have all log traces in compaction job report the cf name and job id #494

udi-speedb opened this issue May 4, 2023 · 2 comments · Fixed by #511
Assignees
@udi-speedb
Labels
bug Something isn't working good first issue Good for newcomers usability

Comments

@udi-speedb
Copy link
Contributor

udi-speedb commented May 4, 2023 •
edited

No description provided.

@udi-speedb udi-speedb added bug Something isn't working good first issue Good for newcomers usability up-for-grabs labels May 4, 2023
@Yuval-Ariel
Copy link
Contributor

there are many other events which dont have a job ID which should IMO. should we not handle those as well while we're at it?

@udi-speedb
Copy link
Contributor Author

I agree. We should. It's just that I had to specially handle this log trace in the log parser...

@udi-speedb udi-speedb self-assigned this May 17, 2023
udi-speedb added a commit that referenced this issue May 17, 2023
@udi-speedb
Have all traces to log in compaction job report both the cf name and …
9fba526 
…job id (#494)
udi-speedb added a commit that referenced this issue May 17, 2023
@udi-speedb
Have all traces to log in compaction job report both the cf name and …
09ad528 
…job id (#494)
@udi-speedb udi-speedb linked a pull request May 17, 2023 that will close this issue
Have all traces to log in compaction job report both the cf name and job id (#494) #511
Merged
@udi-speedb udi-speedb changed the title A compaction job log trace is missing the job id Have all log traces in compaction job report the cf name and job id May 17, 2023
@Guyme Guyme mentioned this issue May 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@udi-speedb udi-speedb

Labels
bug Something isn't working good first issue Good for newcomers usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have all traces to log in compaction job report both the cf name and job id (#494) speedb-io/speedb
2 participants
@Yuval-Ariel @udi-speedb