Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#34: Set purges priority to low instead of high #151

Merged
merged 2 commits into from Sep 28, 2022
Merged

#34: Set purges priority to low instead of high #151

merged 2 commits into from Sep 28, 2022

Conversation

AmnonHanuhov
Copy link
Contributor

No description provided.

@AmnonHanuhov AmnonHanuhov self-assigned this Sep 6, 2022
@AmnonHanuhov AmnonHanuhov linked an issue Sep 6, 2022 that may be closed by this pull request
set purges as Pri::LOW instead of HIGH #34
Closed
isaac-io
isaac-io suggested changes Sep 7, 2022
View reviewed changes
db/db_test2.cc Outdated Show resolved Hide resolved
@isaac-io
Copy link
Contributor

isaac-io commented Sep 7, 2022

Additionally, when running make check locally I see the following failure very early on:

[ RUN      ] DeleteFileTest.BackgroundPurgeIteratorTest
db/deletefile_test.cc:124: Failure
Expected equality of these values:
  required_sst
    Which is: 1
  sst_cnt
    Which is: 3
terminate called after throwing an instance of 'testing::internal::GoogleTestFailureException'
  what():  db/deletefile_test.cc:124: Failure
Expected equality of these values:
  required_sst
    Which is: 1
  sst_cnt
    Which is: 3

Can you look into it and make sure that no other tests are failing?

@AmnonHanuhov AmnonHanuhov force-pushed the 34-set-purges-as-prilow-instead-of-high branch 3 times, most recently from 30526cb to 9d05ae1 Compare September 12, 2022 16:31
@speedb-io speedb-io deleted a comment from isaac-io Sep 13, 2022
@Yuval-Ariel
Copy link
Contributor

in any case, i approved as well to start the CI. seems broken atm so i started it manually - https://github.com/speedb-io/speedb/actions/runs/3043385506

Yuval-Ariel and others added 2 commits September 28, 2022 12:54
@Yuval-Ariel @isaac-io
#34: set purges as Pri::Low
0185fd2
@AmnonHanuhov @isaac-io
db: Fixes for db_test2 and deletefile_test
b258bb8 
Following the change of scheduling purges with low priority, instead of high priority,
tests that tried to block purges from happening by taking up
a slot in the high priority queue, had to instead be scheduled with low piority too.
@isaac-io isaac-io force-pushed the 34-set-purges-as-prilow-instead-of-high branch from 9d05ae1 to b258bb8 Compare September 28, 2022 09:54
@isaac-io isaac-io merged commit f349b10 into main Sep 28, 2022
@isaac-io isaac-io deleted the 34-set-purges-as-prilow-instead-of-high branch September 28, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-io isaac-io isaac-io approved these changes

@Yuval-Ariel Yuval-Ariel Yuval-Ariel approved these changes

Assignees

@AmnonHanuhov AmnonHanuhov

Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set purges as Pri::LOW instead of HIGH
3 participants
@AmnonHanuhov @isaac-io @Yuval-Ariel