Delayed Writes: fix L0 calc bug #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayulas
approved these changes
Dec 24, 2022
| @@ -1013,15 +1013,15 @@ ColumnFamilyData::CalculateWriteDelayDividerAndMaybeUpdateWriteStallCause( | |||
|
|
|||
| // L0 files | |||
| double l0_divider = 1; | |||
| const auto extra_l0_ssts = vstorage->NumLevelFiles(0) - | |||
| const auto extra_l0_ssts = vstorage->l0_delay_trigger_count() - | |||
There was a problem hiding this comment.
it means that you used the incorrect value to calc the write delay , right?
There was a problem hiding this comment.
i think that l0_delay_trigger_count() is used generically which works for universal compaction as well. it worked just as well before but i noticed that l0_delay_trigger_count() is used to count the L0 files before and after that point in the code..
Yuval-Ariel
force-pushed
the
310-delayed-writes-l0-file-calculation-bug
branch
from
2d812fb
to
34aaeaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.