Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Options::periodic_compaction_seconds via C API #741

Merged

Conversation

zaidoon1
Copy link
Contributor

@zaidoon1 zaidoon1 commented Nov 3, 2023

Created this pr in rocksdb repo: facebook/rocksdb#12019 but it's unclear if/when the pr will be accepted. I'm working on switching to speedb so decided to make the change directly here.

@udi-speedb udi-speedb self-requested a review November 3, 2023 06:04
@udi-speedb
Copy link
Contributor

@zaidoon1 - I have just updated our CONTRIBUTING.md guide.
When changing existing rocksdb files, we are adding our license text at the top, before the existing Facebook / LevelDB license text(s).
Please add the license text to db/c_test.c file.
Thanks

Copy link
Collaborator

@maxb-io maxb-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci

@zaidoon1 zaidoon1 force-pushed the zaidoon/c-periodic-compaction-seconds branch from 9a240a6 to fd26f31 Compare November 7, 2023 01:45
@zaidoon1
Copy link
Contributor Author

zaidoon1 commented Nov 7, 2023

@zaidoon1 - I have just updated our CONTRIBUTING.md guide. When changing existing rocksdb files, we are adding our license text at the top, before the existing Facebook / LevelDB license text(s). Please add the license text to db/c_test.c file. Thanks

done

@udi-speedb
Copy link
Contributor

@zaidoon1 - I have just updated our CONTRIBUTING.md guide. When changing existing rocksdb files, we are adding our license text at the top, before the existing Facebook / LevelDB license text(s). Please add the license text to db/c_test.c file. Thanks

done

Thanks. However, next time please don't force push. Just add a new commit.
At the time of the merge, we are squashing all of the commits and make sure the commit message is correct.

udi-speedb
udi-speedb previously approved these changes Nov 7, 2023
@udi-speedb
Copy link
Contributor

Hi,
I am sorry but I have missed the required update to our HISTORY.md file.
Please add a short description of your change under the "Enhancements" section of the Unreleased changes at the top.
Thanks

@udi-speedb udi-speedb self-requested a review November 7, 2023 13:56
@zaidoon1
Copy link
Contributor Author

zaidoon1 commented Nov 8, 2023

Hi, I am sorry but I have missed the required update to our HISTORY.md file. Please add a short description of your change under the "Enhancements" section of the Unreleased changes at the top. Thanks

done

@udi-speedb udi-speedb merged commit d1a4a69 into speedb-io:main Nov 8, 2023
11 checks passed
udi-speedb pushed a commit that referenced this pull request Nov 23, 2023
* Expose Options::periodic_compaction_seconds via C API

* update HISTORY

---------

Co-authored-by: zaidoon <zaidoon@cloudflare.com>
udi-speedb pushed a commit that referenced this pull request Dec 6, 2023
* Expose Options::periodic_compaction_seconds via C API

* update HISTORY

---------

Co-authored-by: zaidoon <zaidoon@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants