Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compaction: Restore SetupForCompaction functionality #788

Merged
merged 4 commits into from
Dec 31, 2023
Merged

Compaction: Restore SetupForCompaction functionality #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e931c5c
Compaction: Restore SetupForCompaction functionality
Yuval-Ariel Dec 25, 2023
3260c88
update history as well
Yuval-Ariel Dec 25, 2023
3c9affb
Merge branch 'main' into restore-normal-hint-for-compaction-files
Yuval-Ariel Dec 25, 2023
4c6c0c0
Merge branch 'main' into restore-normal-hint-for-compaction-files
ofriedma Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Based on RocksDB 8.6.7
* Stall deadlock consists small cfs (#637).
* Proactive Flushes: Fix a race in the ShouldInitiateAnotherFlushMemOnly that may cause the method to return an incorrect answer (#758).
* Fix CI failure after changing compation_readahead_size default to 0 (#794).
* Compaction: Restore SetupForCompaction functionality. Specifically, hint POSIX_FADV_NORMAL for compaction input files.See https://github.com/speedb-io/speedb/issues/787 for full details.

### Miscellaneous
* Remove leftover references to ROCKSDB_LITE (#755).
Expand Down
4 changes: 3 additions & 1 deletion table/block_based/block_based_table_reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,9 @@ Status BlockBasedTable::PrefetchIndexAndFilterBlocks(
return s;
}

void BlockBasedTable::SetupForCompaction() {}
void BlockBasedTable::SetupForCompaction() {
rep_->file->file()->Hint(FSRandomAccessFile::kNormal);
}

TablePinningPolicy* BlockBasedTable::GetPinningPolicy() const {
return rep_->table_options.pinning_policy.get();
Expand Down
Loading