zlib: Update ci and Makefile using a different link #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udi-speedb
previously approved these changes
Jan 25, 2024
udi-speedb
approved these changes
Jan 25, 2024
udi-speedb
previously approved these changes
Jan 25, 2024
udi-speedb
previously approved these changes
Jan 25, 2024
udi-speedb
previously approved these changes
Jan 25, 2024
|
@Yuval-Ariel @udi-speedb |
udi-speedb
previously approved these changes
Jan 25, 2024
udi-speedb
previously approved these changes
Jan 25, 2024
|
should we also keep the version at 1.3 in the makefile? |
This reverts commit 6584a3d.
Yuval-Ariel
changed the title
|
@maxb-io, @speedbmike - We are changing the CI here and leaving the Makefile with the existing URL-s. Seems strange to me. Will this work for somebody building speedb on a clean environment without using our CI? |
udi-speedb
requested changes
Jan 28, 2024
This reverts commit 028f112.
udi-speedb
previously approved these changes
Jan 28, 2024
Yuval-Ariel
changed the title
Yuval-Ariel
changed the title
|
@Yuval-Ariel - What about CMakeLists.txt / cmake? |
@udi-speedb, No idea |
udi-speedb
approved these changes
Jan 28, 2024
shpala
pushed a commit
to shpala/speedb
that referenced
this pull request
Feb 23, 2024
The link in zlib.net is broken every time they release a new version which breaks our download links. Replace those links with a stable link in https://github.com/madler
shpala
pushed a commit
to shpala/speedb
that referenced
this pull request
Feb 23, 2024
The link in zlib.net is broken every time they release a new version which breaks our download links. Replace those links with a stable link in https://github.com/madler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.