Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential 504 Timeout on GET /users/{id}/personal-bests especially when embedding data #170

Open
xTVaser opened this issue Aug 26, 2023 · 0 comments

Comments

@xTVaser
Copy link

xTVaser commented Aug 26, 2023

Related to #95 and #96

Since these endpoints are not paginated when hitting a user that has a large amount of personal bests -- for example this user with over 800 https://www.speedrun.com/api/v1/users/v18q90jn/personal-bests?max=1 it is a very lengthy request if it is a cache-miss

If you then take it a step further and embed more data https://www.speedrun.com/api/v1/users/v18q90jn/personal-bests?embed=game,category.variables,level.variables&max=1 this will instead hit a timeout before the request can complete.

If the request could be paginated this would likely reduce the load and the request could complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant