Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Add link to WebPageTest results page when hover specific data points on chart #36

Closed
rockeynebhwani opened this issue Mar 17, 2017 · 7 comments

Comments

@rockeynebhwani
Copy link

When you hover on a specific data point in chart, currently it shows timestamp of the test and values of key metric.

image

It will be good to add a link to webpagetest results so that users can start investigating using granular data when there is a sudden spike. We can either add a new link or just to save space, we can make timestamp a link.

If making it a link is difficult in hover, it should at least display the testid so that user can self navigate by typing www.webpagetest.org/result/170317_YP_2M5B (Where 170317_YP_2M5B is an example test id)

@eduardoboucas
Copy link
Member

I think this is useful, but I imagine that the vast majority of SpeedTracker users are using the public WebPageTest instance where test results are only held for 30 days. How would we handle this? I'm not keen on adding links that will break, which can confuse people.

@rockeynebhwani
Copy link
Author

So, in that case we can have this test results available for only 30 days for free users and for anybody using private instance, we can have test results it linked forever.

@eduardoboucas
Copy link
Member

I don't think this is going to work. When you hover on the data point it shows you the tooltip, but if you move the mouse to try and click on something inside the tooltip it disappears. This is how Chart.js works and I don't think there's a way to customise this behaviour.

Does that make sense?

@rockeynebhwani
Copy link
Author

Hi @eduardoboucas,

I understand. Can we at least show the test ID within tooltip on hover so we know which test to look for in webpagestest in case we need to dig deeper?

Rockey

@eduardoboucas
Copy link
Member

@rockeynebhwani This was added in 1.1.0. Can you update your dashboard and let me know if it works?

Thanks.

@eduardoboucas
Copy link
Member

Released 1.1.1, with a label below each chart explaining what happens when you click on a data point.

@eduardoboucas
Copy link
Member

Added in 1.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants