Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing test result files are not cleared #76

Closed
tkohlmeier opened this issue Mar 10, 2021 · 3 comments · Fixed by spekt/testlogger#18
Closed

Existing test result files are not cleared #76

tkohlmeier opened this issue Mar 10, 2021 · 3 comments · Fixed by spekt/testlogger#18

Comments

@tkohlmeier
Copy link

tkohlmeier commented Mar 10, 2021 •
edited
Loading

When running a test with an existing test result file, the old content is not cleared. The new content is written into the old file, overwriting characters that have been there before.

Example:

Old file content:

example
content
bla

New results:

new example
test

This results in:

new example
testent
bla

Not sure if this is a problem of nunit.testlogger or .NET Core.
@codito
Copy link
Collaborator

codito commented Mar 10, 2021

@tkohlmeier this appears to be a regression. I will create a fix shortly.

codito added a commit to codito/testlogger that referenced this issue Mar 10, 2021
@codito
fix: test results must overwrite an existing file.
115a0e7 
Fixes spekt/nunit.testlogger#76
@codito codito mentioned this issue Mar 10, 2021
Merged
codito added a commit to spekt/testlogger that referenced this issue Mar 10, 2021
@codito
fix: test results must overwrite an existing file. (#18)
f5704c0 
Fixes spekt/nunit.testlogger#76
@codito codito reopened this Mar 10, 2021
codito added a commit to codito/nunit.testlogger that referenced this issue Mar 10, 2021
@codito
chore: upgrade testlogger to 3.0.31 with fix for spekt#76.
f4a57b3
codito added a commit that referenced this issue Mar 10, 2021
@codito
chore: upgrade testlogger to 3.0.31 with fix for #76. (#77)
e3bac10
@codito
Copy link
Collaborator

codito commented Mar 10, 2021

Pushed a fix to nuget: v3.0.97. Please try it out. Thank you for reporting this issue.

@codito codito closed this as completed Mar 10, 2021
This was referenced Mar 11, 2021
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Open
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 11, 2021
Closed
Closed
Merged
Closed
Merged
@tkohlmeier
Copy link
Author

I can confirm that the issue is fixed with the current version. Thanks for fixing this so quickly!

@dependabot dependabot bot mentioned this issue Mar 17, 2021
Closed
@renovate renovate bot mentioned this issue Jul 22, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: test results must overwrite an existing file. codito/testlogger
2 participants
@codito @tkohlmeier