Adding framework and assembly tokens for test output path #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codito
reviewed
May 17, 2019
src/NUnit.Xml.TestLogger.TestAdapter/NUnit.Xml.TestLogger.TestAdapter.csproj
Outdated
Show resolved
Hide resolved
|
OK I just added a small test for the log file tokens. Tried to be minimally invasive in existing tests without reinventing the wheel. |
codito
approved these changes
May 20, 2019
codito
reviewed
May 20, 2019
| { | ||
| string[] expectedResultsFiles = new string[] | ||
| { | ||
| Path.Combine(DotnetTestFixture.RootDirectory, "NUnit.Xml.TestLogger.NetMulti.Tests.NetFramework46.test-results.xml"), |
There was a problem hiding this comment.
Tests are failing in unix because these file names need to be case sensitive (caps NET).
NUnit.Xml.TestLogger.NetMulti.Tests.NETFramework46.test-results.xml
NUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp20.test-results.xml
|
🎆 🚀 Thank you! Tests are failing on unix due to a minor error, added a commit fixing it. Will merge after CI is green! |
|
When can I consume these changes via a package on nuget @codito? |
|
Just pushed an update! https://www.nuget.org/packages/NunitXml.TestLogger/2.1.41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #24