Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabpot/goutte #181

Closed
nadar opened this issue May 17, 2023 · 14 comments
Closed

fabpot/goutte #181

nadar opened this issue May 17, 2023 · 14 comments

Comments

@nadar
Copy link
Contributor

nadar commented May 17, 2023

it seems that one of your deps is abandoned, maybe consider using the suggested replacement? Or is there a specific reason?

Package fabpot/goutte is abandoned, you should avoid using it. Use symfony/browser-kit instead.

@spekulatius
Copy link
Owner

Hey @nadar

yeah, Goutte is more or less just a wrapper around other packages at this point. It looks as if using the original dependencies instead is the way to go. I'm pretty busy atm. Do you think you could look into this? Otherwise it will have to wait a bit.

Cheers,
Peter

@monsefsolutions
Copy link

First of all, thank you @spekulatius for this great scraper and all the work you put into it. I really appreciate it.

I get a similar error like @nadar mentioned when switching to PHP 8.2.6.

The "Goutte\Client" class is deprecated, use "Symfony\Component\BrowserKit\HttpBrowser" instead

I wish I could help with solving the error, but unfortunately, I'm not that familiar with Goutte and BrowserKit. I will wait patiently for the fix and in the meantime switch back to PHP 7.4.x. Again, thanks for this amazing tool.

@spekulatius
Copy link
Owner

Hello @nadar and @monsefsolutions,

I've pushed a branch called 181-switch-from-goutte-to-browser-kit to address this issue by switching the base lib. Could you clone the repo into your vendor folder and test this? Thank you!

Cheers,
Peter

@nadar
Copy link
Contributor Author

nadar commented Jun 1, 2023

In order to test branches, packagist automatically publishes branches. you can access them by using dev-<branch-name>. So in order to test i just did "spekulatius/phpscraper": "dev-181-switch-from-goutte-to-browser-kit as 1.0.2" and composer u.

Looks good so far, will make some tests. thanks

@monsefsolutions
Copy link

Hi @spekulatius,

Thank you for your quick response, really appreciate it. I just copied the files from the new branch and I do not get any errors anymore with PHP 8.2.6 active. Thank you!

@spekulatius
Copy link
Owner

Sounds like we are on a good path. I'll check it a bit more merge it and tag a new major release (as the interface changes)

@spekulatius
Copy link
Owner

I've merged the branch and will tag a new major release once a number of smaller fixes have been included @nadar & @monsefsolutions.

@nadar
Copy link
Contributor Author

nadar commented Jun 2, 2023

@spekulatius great, thanks for taking care 👍

@monsefsolutions
Copy link

@spekulatius Thank you for the quick responses and solution!

@spekulatius
Copy link
Owner

Hello @nadar & @monsefsolutions

I've pushed the last changes for v2. Could you give the v2 branch a spin and see if you notice any problems before I merge and tag it? Thank you in advance!

Peter

@monsefsolutions
Copy link

monsefsolutions commented Jun 6, 2023 via email

@spekulatius
Copy link
Owner

Okay, let me know if you find any issues @monsefsolutions 👍

@spekulatius
Copy link
Owner

Hello @monsefsolutions and @nadar,

I've tagged a new major release. Feel free to give it a try and let me know if you find any issues.

Cheers,
Peter

@nadar
Copy link
Contributor Author

nadar commented Jun 19, 2023

Thanks! I just upgraded and tested to 2.0, works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants