-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fabpot/goutte #181
Comments
Hey @nadar yeah, Goutte is more or less just a wrapper around other packages at this point. It looks as if using the original dependencies instead is the way to go. I'm pretty busy atm. Do you think you could look into this? Otherwise it will have to wait a bit. Cheers, |
First of all, thank you @spekulatius for this great scraper and all the work you put into it. I really appreciate it. I get a similar error like @nadar mentioned when switching to PHP 8.2.6.
I wish I could help with solving the error, but unfortunately, I'm not that familiar with Goutte and BrowserKit. I will wait patiently for the fix and in the meantime switch back to PHP 7.4.x. Again, thanks for this amazing tool. |
Hello @nadar and @monsefsolutions, I've pushed a branch called Cheers, |
In order to test branches, packagist automatically publishes branches. you can access them by using Looks good so far, will make some tests. thanks |
Hi @spekulatius, Thank you for your quick response, really appreciate it. I just copied the files from the new branch and I do not get any errors anymore with PHP 8.2.6 active. Thank you! |
Sounds like we are on a good path. I'll check it a bit more merge it and tag a new major release (as the interface changes) |
I've merged the branch and will tag a new major release once a number of smaller fixes have been included @nadar & @monsefsolutions. |
@spekulatius great, thanks for taking care 👍 |
@spekulatius Thank you for the quick responses and solution! |
Hello @nadar & @monsefsolutions I've pushed the last changes for v2. Could you give the Peter |
Hi Peter,
Thank you again for the effort! I will test it at the end of this week and
let you know.
|
Okay, let me know if you find any issues @monsefsolutions 👍 |
Hello @monsefsolutions and @nadar, I've tagged a new major release. Feel free to give it a try and let me know if you find any issues. Cheers, |
Thanks! I just upgraded and tested to 2.0, works 👍 |
it seems that one of your deps is abandoned, maybe consider using the suggested replacement? Or is there a specific reason?
The text was updated successfully, but these errors were encountered: