Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Eq1, Show1, etc. for instances #6

Closed
andrewthad opened this issue Aug 23, 2017 · 3 comments · Fixed by #8
Closed

Use Eq1, Show1, etc. for instances #6

andrewthad opened this issue Aug 23, 2017 · 3 comments · Fixed by #8

Comments

@andrewthad
Copy link
Contributor

Since base-4.9, the Data.Functor.Classes module has been available (previously, it was available through the transformers library). It would be nice if the instances for Fix relied on these instead of using FlexibleContexts. I am willing to PR this if you would accept it.
@anton-k
Copy link
Contributor

anton-k commented Aug 24, 2017 •
edited
Loading

PRs are welcome!

But can you make it with conditionals on GHC version. So that it could work in previous versions of GHC

@andrewthad
Copy link
Contributor Author

Absolutely.

@andrewthad andrewthad mentioned this issue Aug 24, 2017
Merged
@andrewthad
Copy link
Contributor Author

PR is up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provide instances for Eq,Ord,Show,Read using higher-order typeclasses andrewthad/data-fix
2 participants
@anton-k @andrewthad