Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

177 update starlark version to expose printhandler objects #180

Merged
merged 17 commits into from
May 3, 2023
Merged

177 update starlark version to expose printhandler objects #180

merged 17 commits into from
May 3, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Apr 2, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates our current version of star-lark to a newer commit where PrintHandler is avaiblable.

Which issue(s) this PR fixes:

Fixes #177

@hulto hulto linked an issue Apr 2, 2023 that may be closed by this pull request
Update starlark version to expose PrintHandler objects. #177
Closed
@codecov
Copy link

codecov bot commented Apr 2, 2023 •
edited

Codecov Report

Merging #180 (f5ad462) into main (73836ac) will decrease coverage by 0.37%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   69.49%   69.12%   -0.37%     
==========================================
  Files          75       75              
  Lines        3809     3803       -6     
==========================================
- Hits         2647     2629      -18     
- Misses       1077     1089      +12     
  Partials       85       85
Impacted Files Coverage Δ
implants/eldritch/src/assets.rs 38.70% <0.00%> (-2.67%) ⬇️
implants/eldritch/src/file.rs 66.33% <0.00%> (-1.35%) ⬇️
implants/eldritch/src/pivot.rs 47.36% <0.00%> (-1.73%) ⬇️
implants/eldritch/src/process.rs 38.23% <0.00%> (-2.39%) ⬇️
implants/eldritch/src/sys.rs 48.88% <0.00%> (-2.28%) ⬇️
implants/eldritch/src/process/list_impl.rs 91.30% <80.00%> (-2.29%) ⬇️
implants/eldritch/src/file/template_impl.rs 100.00% <100.00%> (ø)
implants/eldritch/src/lib.rs 93.95% <100.00%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hulto
hulto commented Apr 2, 2023
View reviewed changes
implants/eldritch/src/lib.rs Outdated Show resolved Hide resolved
@hulto
Copy link
Collaborator Author

hulto commented Apr 3, 2023

Codecov Report

Merging #180 (dcfb267) into main (ceab700) will decrease coverage by 3.34%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   69.33%   65.99%   -3.34%     
==========================================
  Files          75       75              
  Lines        3779     3735      -44     
==========================================
- Hits         2620     2465     -155     
- Misses       1078     1189     +111     
  Partials       81       81

Impacted Files Coverage Δ
implants/eldritch/src/assets.rs 38.70% <0.00%> (-2.67%) ⬇️
implants/eldritch/src/file.rs 66.33% <0.00%> (-1.35%) ⬇️
implants/eldritch/src/pivot.rs 47.36% <0.00%> (-1.73%) ⬇️
implants/eldritch/src/process.rs 38.23% <0.00%> (-2.39%) ⬇️
implants/eldritch/src/sys.rs 48.88% <0.00%> (-2.28%) ⬇️
implants/eldritch/src/process/list_impl.rs 89.55% <60.00%> (-4.04%) ⬇️
implants/eldritch/src/file/template_impl.rs 100.00% <100.00%> (ø)
implants/eldritch/src/lib.rs 93.95% <100.00%> (-0.05%) ⬇️
... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Ignoring code cove failures. No clear way to add tests to the boiler plate.

@hulto hulto mentioned this pull request Apr 6, 2023
Closed
@hulto
Copy link
Collaborator Author

hulto commented Apr 9, 2023

This PR also fixes usernames for windows since it required an update to the sysinfo package.
image

@hulto hulto added dependencies Pull requests that update a dependency file eldritch Related to the Eldritch language labels Apr 9, 2023
Cictrone
Cictrone approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#stellarPR

@Cictrone Cictrone merged commit 9f3cbbd into main May 3, 2023
9 of 11 checks passed
@Cictrone Cictrone deleted the 177-update-starlark-version-to-expose-printhandler-objects branch May 3, 2023 22:56
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
a6ed06b 
 
177 update starlark version to expose printhandler objects (#180)

* Updated starlark to latest commit.

* Update golem starlark version.

* Refactor eval stuff.

* Actually update to latest.

* alloc_list was removed from starlark.

* Added new allocative crate.

* Updated rust version to match starlark.

* Nothing works abandoning

* pause

* Update eldritch starlark version.

* Updating eval from starlark.

* Updated sysinfo to reslove ntapi error

* Updated list impl for new sysinfo crate

* Update process list to new sysinfo version

* Removed uneeded feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file eldritch Related to the Eldritch language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update starlark version to expose PrintHandler objects.
2 participants
@hulto @Cictrone