Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Prevent Beacon Renaming #353

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[bugfix] Prevent Beacon Renaming #353

merged 1 commit into from
Nov 6, 2023

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Prevents beacons from being renamed by making the name field immutable.

Which issue(s) this PR fixes:

Fixes #350

@KCarretto KCarretto requested a review from hulto November 6, 2023 02:23
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #353 (14ebcd0) into main (346f673) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   75.21%   75.21%           
=======================================
  Files         103      103           
  Lines        6810     6811    +1     
=======================================
+ Hits         5122     5123    +1     
  Misses       1593     1593           
  Partials       95       95           
Files Coverage Δ
tavern/internal/ent/schema/beacon.go 60.31% <100.00%> (+0.64%) ⬆️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@hulto hulto merged commit 2bfc11f into main Nov 6, 2023
8 checks passed
@hulto hulto deleted the fix-beacon-renaming branch November 6, 2023 02:44
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
make beacon.name immutable (#353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beacon name changes on check-in
3 participants