Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull lfs objects #356

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Pull lfs objects #356

merged 2 commits into from
Nov 8, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Nov 6, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR runs git lfs pull once after checking the docker build pulls the repo.
This will make sure resource files like the tavern logo are pulled in for the build properly prenting issues where assets are just references.

Follow on to commit: 346f673

image

version https://git-lfs.github.com/spec/v1
oid sha256:5849c38f5bb63022aad0b733b6d205f4480e50aa1298ad9b6bfe7373c8985009
size 10979

Which issue(s) this PR fixes:

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #356 (e39dbd7) into main (48b447a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   75.11%   75.13%   +0.02%     
==========================================
  Files         103      103              
  Lines        6818     6818              
==========================================
+ Hits         5121     5123       +2     
+ Misses       1601     1599       -2     
  Partials       96       96              

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@hulto hulto merged commit 9b0df00 into main Nov 8, 2023
8 checks passed
@hulto hulto deleted the git-lfs-pull branch November 8, 2023 01:37
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Pull lfs objects (#356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants