Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time and sleep #360

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Time and sleep #360

merged 3 commits into from
Nov 15, 2023

Conversation

jabbate19
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Starts the time library and adds the sleep function

Which issue(s) this PR fixes:

Fixes #327

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #360 (cb2ae6d) into main (eb4ae10) will decrease coverage by 0.22%.
The diff coverage is 45.23%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   75.21%   75.00%   -0.22%     
==========================================
  Files         103      105       +2     
  Lines        6811     6853      +42     
==========================================
+ Hits         5123     5140      +17     
- Misses       1593     1618      +25     
  Partials       95       95              
Files Coverage Δ
implants/lib/eldritch/src/lib.rs 92.82% <100.00%> (+0.06%) ⬆️
implants/lib/eldritch/src/time/sleep_impl.rs 100.00% <100.00%> (ø)
implants/lib/eldritch/src/time.rs 23.33% <23.33%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hulto hulto merged commit 635583b into main Nov 15, 2023
6 checks passed
@hulto hulto deleted the time branch November 15, 2023 23:39
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Time and sleep (#360)

* Time and sleep

* Docs

---------

Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement eldritch time.sleep function
2 participants