Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sys.get_reg() function to eldritch. #362

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Add sys.get_reg() function to eldritch. #362

merged 7 commits into from
Nov 14, 2023

Conversation

adm1nPanda
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Added sys.get_reg() function to eldritch. only installs on windows systems.
$> sys.get_reg("HKEY_LOCAL_MACHINE","SOFTWARE\Microsoft\Windows\CurrentVersion")
{
"ProgramFilesDir": "C:\Program Files",
"CommonFilesDir": "C:\Program Files\Common Files",
"ProgramFilesDir (x86)": "C:\Program Files (x86)",
"CommonFilesDir (x86)": "C:\Program Files (x86)\Common Files",
"CommonW6432Dir": "C:\Program Files\Common Files",
"DevicePath": "%SystemRoot%\inf",
"MediaPathUnexpanded": "%SystemRoot%\Media",
"ProgramFilesPath": "%ProgramFiles%",
"ProgramW6432Dir": "C:\Program Files",
"SM_ConfigureProgramsName": "Set Program Access and Defaults",
"SM_GamesName": "Games"
}

Which issue(s) this PR fixes:

Fixes #358

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #362 (fcae82a) into main (c30f20c) will decrease coverage by 0.23%.
The diff coverage is 57.33%.

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   75.13%   74.91%   -0.23%     
==========================================
  Files         103      104       +1     
  Lines        6818     6892      +74     
==========================================
+ Hits         5123     5163      +40     
- Misses       1599     1633      +34     
  Partials       96       96              
Files Coverage Δ
implants/lib/eldritch/src/lib.rs 92.75% <100.00%> (ø)
implants/lib/eldritch/src/sys.rs 49.39% <50.00%> (+0.03%) ⬆️
implants/lib/eldritch/src/sys/get_reg_impl.rs 57.14% <57.14%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple fixes but looks really good. Love the testing 🤌

implants/lib/eldritch/src/sys/get_reg_impl.rs Outdated Show resolved Hide resolved
implants/lib/eldritch/src/sys/get_reg_impl.rs Outdated Show resolved Hide resolved
docs/_docs/user-guide/eldritch.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change to remove unwrap but then good to send 🚀

implants/lib/eldritch/src/sys/get_reg_impl.rs Outdated Show resolved Hide resolved
@hulto hulto merged commit c9dae76 into spellshift:main Nov 14, 2023
6 checks passed
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add sys.get_reg() function to eldritch. (#362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] implement sys.reg_get(reg_path: String)
2 participants