Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dll_reflect and alphabetize. #391

Merged
merged 4 commits into from
Dec 17, 2023
Merged

dll_reflect and alphabetize. #391

merged 4 commits into from
Dec 17, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Dec 10, 2023

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Adds docs for sys.dll_reflect and alphabetizes functions and modules.

Which issue(s) this PR fixes:

Fixes #389

@hulto hulto linked an issue Dec 10, 2023 that may be closed by this pull request
[bug] Missing docs for sys.dll_reflect #389
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7bee71) 71.13% compared to head (9486618) 71.13%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files         109      109           
  Lines        8071     8071           
=======================================
  Hits         5741     5741           
  Misses       2221     2221           
  Partials      109      109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jabbate19
jabbate19 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alphabet is difficult

@hulto hulto merged commit 836517f into main Dec 17, 2023
8 checks passed
@hulto hulto deleted the 389-bug-missing-docs-for-sysdll_reflect branch December 17, 2023 21:52
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
83d5035 
 
dll_reflect and alphabetize. (#391)

* dll_reflect docs

* Alphabetize docs

* Add examples to docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabbate19 jabbate19 jabbate19 approved these changes

@Cictrone Cictrone Awaiting requested review from Cictrone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Missing docs for sys.dll_reflect
2 participants
@hulto @jabbate19