Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

395 bug imix has no delay between failed check ins #403

Merged
merged 5 commits into from
Dec 17, 2023
Merged

395 bug imix has no delay between failed check ins #403

merged 5 commits into from
Dec 17, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Dec 16, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR:

  • Removes ? usage from main loop and instead catches the error and continues.
  • Adds delay on failed functions.

Which issue(s) this PR fixes:

Fixes #395

@hulto hulto added bug Something isn't working imix labels Dec 16, 2023
@hulto hulto linked an issue Dec 16, 2023 that may be closed by this pull request
[bug] Imix has no delay between failed check-ins. #395
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2023 •
edited

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (7819591) 71.52% compared to head (7e78f28) 71.13%.

Files Patch % Lines
implants/imix/src/main.rs 0.00% 49 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   71.52%   71.13%   -0.39%     
==========================================
  Files         109      109              
  Lines        8027     8071      +44     
==========================================
  Hits         5741     5741              
- Misses       2177     2221      +44     
  Partials      109      109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jabbate19
jabbate19 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hulto hulto merged commit 4800ac3 into main Dec 17, 2023
6 of 8 checks passed
@hulto hulto deleted the 395-bug-imix-has-no-delay-between-failed-check-ins branch December 17, 2023 19:29
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
44b3a8f 
 
395 bug imix has no delay between failed check ins (#403)

* Add client sleep on callback failure.

* Remove panicy question marks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabbate19 jabbate19 jabbate19 approved these changes

@Cictrone Cictrone Awaiting requested review from Cictrone

@KCarretto KCarretto Awaiting requested review from KCarretto

Assignees
No one assigned
Labels
bug Something isn't working imix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Imix has no delay between failed check-ins.
2 participants
@hulto @jabbate19