-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp format to/from epoch #413
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 71.39% 71.45% +0.05%
==========================================
Files 113 115 +2
Lines 8800 8832 +32
==========================================
+ Hits 6283 6311 +28
- Misses 2408 2412 +4
Partials 109 109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change to docs otherwise LGTM
@@ -823,6 +823,14 @@ sys.shell("ls /nofile") | |||
|
|||
### time.sleep | |||
|
|||
`time.format_to_epoch(input: str, format: str) -> int` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide examples of the formats as well as a link to the docs on all acceptable formats whether that's the crate specific or the generic time formats.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Adds methods to re-format times to/from UNIX Epoch. Uses Chrono for formatting and parsing.
Which issue(s) this PR fixes:
Fixes #77
Fixes #78