Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform-search): Add platform search for beacons #416

Merged
merged 3 commits into from
Dec 27, 2023
Merged

feat(platform-search): Add platform search for beacons #416

merged 3 commits into from
Dec 27, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Dec 27, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds platform filter to beacon search
  • Changes order of creating a quest so beacons get selected first
  • Changes beacon options to used beacon tile component

Which issue(s) this PR fixes:

Fixes #369

Screenshots

Screenshot 2023-12-27 at 4 50 07 PM

@cmp5987 cmp5987 requested a review from hulto December 27, 2023 22:50
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f207c64) 71.17% compared to head (b1621be) 71.17%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files         109      109           
  Lines        8084     8084           
=======================================
  Hits         5754     5754           
  Misses       2221     2221           
  Partials      109      109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hulto
hulto approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmp5987 cmp5987 merged commit 9f9f863 into main Dec 27, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp/add-platform-to-beacon-filter branch December 27, 2023 23:27
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987
4e35584 
 
feat(platform-search): Add platform search for beacons (#416)

* feat(platform-search): Add platform search for beacons

* fix(build): Build UI

* fix(back): Remove back button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add platform as a beacon search field
2 participants
@cmp5987 @hulto