Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] gRPC File Download API #447

Merged
merged 6 commits into from
Jan 21, 2024
Merged

[feature] gRPC File Download API #447

merged 6 commits into from
Jan 21, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new gRPC method for downloading files.

Cictrone
Cictrone previously approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure imix has that cool new method, but otherwise lgtm

hulto
hulto reviewed Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.realm.pub/dev-guide/tavern
Should we update the docs around the download API?

hulto
hulto previously approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM

tavern/internal/c2/api_download_file.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (3576b5c) 71.46% compared to head (7ff3d25) 71.30%.

Files Patch % Lines
implants/lib/c2/src/c2.rs 0.00% 24 Missing ⚠️
tavern/internal/c2/api_download_file.go 77.50% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   71.46%   71.30%   -0.17%     
==========================================
  Files         115      116       +1     
  Lines        8835     8900      +65     
==========================================
+ Hits         6314     6346      +32     
- Misses       2412     2442      +30     
- Partials      109      112       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KCarretto KCarretto merged commit 1b8bf51 into main Jan 21, 2024
6 checks passed
@KCarretto KCarretto deleted the grpc-download-file branch January 21, 2024 01:41
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
659b39d 
 
[feature] gRPC File Download API (#447)

* created gRPC file download API

* regenerate entgo

* remove hash parameter, use gRPC headers instead

* generate rust gRPC bindings

* Updated documentation

* Rename header to sha3-256-checksum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone left review comments

@hulto hulto hulto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KCarretto @Cictrone @hulto