Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Include quest name on gRPC task #453

Merged
merged 4 commits into from
Jan 21, 2024
Merged

[feature] Include quest name on gRPC task #453

merged 4 commits into from
Jan 21, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Updates the gRPC Task protobuf to include the name of the associated Quest.

Which issue(s) this PR fixes:

Fixes #410

@KCarretto KCarretto requested a review from hulto January 21, 2024 19:24
hulto
hulto previously approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EZ

@KCarretto KCarretto merged commit 3306759 into main Jan 21, 2024
6 checks passed
@KCarretto KCarretto deleted the grpc-quest-name branch January 21, 2024 22:53
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
cc3dd04 
 
[feature] Include quest name on gRPC task (#453)

* include quest name on gRPC task

* fix imix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add quest name to grpc Task
2 participants
@KCarretto @hulto