Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cp host view #454

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Cp host view #454

merged 5 commits into from
Jan 21, 2024

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Jan 21, 2024 •
edited

What type of PR is this?

/kind feature
/kind front-end

What this PR does / why we need it:

  • Adds a host list view
  • Adds a host details view
  • Adds principal to beacon tiles
  • Adds principal to test data
  • Expands useTasks to handle default hostId param
  • Moves reused components to /components folder instead of /Task

Screenshots

Screenshot 2024-01-21 at 3 06 53 PM Screenshot 2024-01-21 at 3 07 23 PM

@cmp5987 cmp5987 added feature New feature or request Frontend labels Jan 21, 2024
@cmp5987 cmp5987 requested a review from hulto January 21, 2024 20:07
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feb4640) 71.53% compared to head (5378a79) 71.53%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   71.53%   71.53%           
=======================================
  Files         118      118           
  Lines        9006     9009    +3     
=======================================
+ Hits         6442     6445    +3     
  Misses       2441     2441           
  Partials      123      123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit a7e3eff into main Jan 21, 2024
8 checks passed
@cmp5987 cmp5987 deleted the cp-host-view branch January 21, 2024 22:02
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987
1df41ca 
 
Cp host view (#454)

* feat(host): Add host details

* fix(host): Format host stats

* fix(build): Run build UI

* fix(sorting): Fix sorting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
feature New feature or request Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmp5987 @hulto