Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint warnings. #455

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Fix lint warnings. #455

merged 8 commits into from
Jan 22, 2024

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jan 21, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cleans up most of the compiler warnings with the exception of windows specific unused vars and const_frozen_string in the insert_dict_kv.

Which issue(s) this PR fixes:

Fixes #451

@hulto hulto linked an issue Jan 21, 2024 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 128 lines in your changes are missing coverage. Please review.

Comparison is base (3306759) 71.55% compared to head (b8476ea) 71.82%.

Files Patch % Lines
implants/lib/eldritch/src/file/find_impl.rs 0.00% 60 Missing ⚠️
implants/imix/src/main.rs 0.00% 25 Missing ⚠️
implants/imix/src/init.rs 12.50% 14 Missing ⚠️
...mplants/lib/eldritch/src/sys/write_reg_hex_impl.rs 93.79% 8 Missing ⚠️
...mplants/lib/eldritch/src/sys/write_reg_int_impl.rs 93.79% 8 Missing ⚠️
...mplants/lib/eldritch/src/sys/write_reg_str_impl.rs 93.79% 8 Missing ⚠️
implants/imix/src/tasks.rs 0.00% 4 Missing ⚠️
implants/imix/src/install.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   71.55%   71.82%   +0.27%     
==========================================
  Files         118      118              
  Lines        9013     9302     +289     
==========================================
+ Hits         6449     6681     +232     
- Misses       2441     2498      +57     
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cictrone Cictrone merged commit 9600009 into main Jan 22, 2024
8 checks passed
@Cictrone Cictrone deleted the 451-cleanup-rust-compiler-warnings branch January 22, 2024 01:07
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Fix lint warnings. (#455)

* Fix lint warnings.

* FIx unused_imports

* Cleanup debug assert lint warns.

* Missed one.

* More debug_asserts.

* fix test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup rust compiler warnings
2 participants