-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Added basic validation for parameters #456
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 71.32% 71.32% -0.01%
==========================================
Files 119 120 +1
Lines 9379 9411 +32
==========================================
+ Hits 6690 6712 +22
- Misses 2566 2573 +7
- Partials 123 126 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but looks good
}, | ||
{ | ||
name: "Multiple", | ||
data: `[{"name":"an-int","type":"int32"},{"name":"a-str","type": "string"}]`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually support int type in params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No not yet
What type of PR is this?
/kind feature
What this PR does / why we need it:
Ensures parameters & parameter definitions are valid JSON.
Which issue(s) this PR fixes:
Fixes #173