Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quest name change #475

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Quest name change #475

merged 3 commits into from
Jan 23, 2024

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Jan 23, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Removes faker
  • Swaps out a 1000 string array of names for quests

Which issue(s) this PR fixes:

#474

Screenshot

  • Name of quest now populated when not adjusted from randomized list
Screenshot 2024-01-22 at 8 01 33 PM

@cmp5987 cmp5987 requested a review from hulto January 23, 2024 01:03
hulto
hulto approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df4283f) 66.04% compared to head (a366eac) 70.65%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   66.04%   70.65%   +4.60%     
==========================================
  Files         122      122              
  Lines        8998     9573     +575     
==========================================
+ Hits         5943     6764     +821     
+ Misses       2921     2675     -246     
  Partials      134      134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmp5987 cmp5987 merged commit 8e78eb2 into main Jan 23, 2024
8 checks passed
@cmp5987 cmp5987 deleted the quest-name-change branch January 23, 2024 01:22
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987
3c8420e 
 
Quest name change (#475)

* fix(questname): Change source of quest name, remove faker

* fix(build): Run build UI

* fix(package): Remove faker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmp5987 @hulto