Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Improve Test Coverage #482

Merged
merged 10 commits into from
Jan 23, 2024
Merged

[cleanup] Improve Test Coverage #482

merged 10 commits into from
Jan 23, 2024

Conversation

KCarretto
Copy link
Collaborator

@KCarretto KCarretto commented Jan 23, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Adds additional testing and bumps that coverage metric.
  • Adds new HTTP_LISTEN_ADDR env var for configuring http bind.
  • Adds new ENABLE_TEST_RUN_AND_EXIT env var for shutting down the server immediately after starting it.

@KCarretto KCarretto requested a review from hulto January 23, 2024 03:00
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (183e36d) 69.65% compared to head (4d3a04f) 71.32%.

Files Patch % Lines
tavern/internal/c2/api_report_task_output.go 76.31% 6 Missing and 3 partials ⚠️
tavern/main.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   69.65%   71.32%   +1.66%     
==========================================
  Files         121      122       +1     
  Lines        9531     9547      +16     
==========================================
+ Hits         6639     6809     +170     
+ Misses       2779     2607     -172     
- Partials      113      131      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KCarretto KCarretto merged commit 3d92ba2 into main Jan 23, 2024
6 checks passed
@KCarretto KCarretto deleted the tavern-coverage branch January 23, 2024 05:22
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
[cleanup] Improve Test Coverage (#482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants