Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Structured Reporting - Files #496

Merged
merged 7 commits into from
Jan 23, 2024
Merged

[feature] Structured Reporting - Files #496

merged 7 commits into from
Jan 23, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds a new HostFile ent
    • New namespacing is required to avoid beacons having control over tome files
  • Renames Process to HostProcess
  • Adds new fields to HostProcess to encompass the info exposed by eldritch
  • Uses c2pb enums directly in our ent definitions, updates GraphQL bindings
  • Additional testing as needed

@KCarretto KCarretto requested a review from hulto January 23, 2024 21:49
Cictrone
Cictrone previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cictrone Cictrone merged commit 7fd5b31 into main Jan 23, 2024
6 checks passed
@Cictrone Cictrone deleted the grpc-structured-files-and-proc branch January 23, 2024 22:29
hulto
hulto approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype hype

KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
f5b8f2c 
 
[feature] Structured Reporting - Files (#496)

* update protobufs

* Use c2pb enum on process ent, rename to HostProcess, add fields

* Migrate to c2pb for Host_Platform enum

* Fix enums, added tests

* Added ReportFile gRPC API

* Generate Rust Bindings

* minor cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone approved these changes

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KCarretto @Cictrone @hulto