Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Metrics #503

Merged
merged 4 commits into from
Jan 24, 2024
Merged

[feature] Metrics #503

merged 4 commits into from
Jan 24, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds a new "/metrics" endpoint, hosted on another HTTP server (so that it may be restricted to 127.0.0.1)
  • Adds two new environment vars for configuration
    • ENABLE_METRICS enables the metrics HTTP server and endpoint
    • HTTP_METRICS_LISTEN_ADDR configures the ip:port to bind the metrics http server to.

Which issue(s) this PR fixes:

Fixes #135

@KCarretto KCarretto requested a review from hulto January 24, 2024 01:11
@KCarretto KCarretto merged commit d89e576 into main Jan 24, 2024
4 checks passed
@KCarretto KCarretto deleted the metrics branch January 24, 2024 01:19
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
2081c1b 
 
[feature] Metrics (#503)

* Add basic metrics

* Updated Docs

* Remove http errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintain history of checkin timestamps
2 participants
@KCarretto @hulto