Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tome for printing environment variables #504

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Alextibtab
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds tome for printing out environment variables

Which issue(s) this PR fixes:

Fixes #491

Added eldritch code and metadata file
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f5be34) 72.27% compared to head (995568e) 70.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   72.27%   70.91%   -1.37%     
==========================================
  Files          85      126      +41     
  Lines        7509    10001    +2492     
==========================================
+ Hits         5427     7092    +1665     
- Misses       2082     2764     +682     
- Partials        0      145     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alextibtab
Copy link
Contributor Author

Not sure why the coverage dropped by 1.36% don't know if it's just a case of running it again and 🙏

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP 🪦 I'm not sure either but it looks good to me.

@hulto hulto merged commit 2ee51b1 into spellshift:main Jan 25, 2024
7 of 8 checks passed
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Issue #491 Get env tome (#504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement get env tome
2 participants