Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Eldritch & Imix Refactor #509

Merged
merged 13 commits into from
Jan 27, 2024
Merged

[feature] Eldritch & Imix Refactor #509

merged 13 commits into from
Jan 27, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

  • Implements an eldritch::Runtime
  • Refactors imix and eldritch
  • Refactors our protobufs
  • What doesn't it do might be a shorter answer

Cictrone
Cictrone requested changes Jan 27, 2024
View reviewed changes
implants/imix/src/install.rs
@@ -1,127 +0,0 @@
use std::collections::HashMap;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install is gone D:

Cictrone
Cictrone requested changes Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uno más

implants/golem/src/main.rs Outdated Show resolved Hide resolved
Cictrone
Cictrone previously approved these changes Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KCarretto KCarretto merged commit bfd1eb9 into main Jan 27, 2024
0 of 6 checks passed
@KCarretto KCarretto deleted the rust-devs-sadge branch January 27, 2024 06:15
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
66b48bf 
 
[feature] Eldritch & Imix Refactor (#509)

* Refactors eldritch, introduces `eldritch::Runtime`
* Refactors imix, introduces `imix::Agent` and `imix::Config`
* Refactors our protobufs, creating new `eldritch` package for language specific types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KCarretto @Cictrone