Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

445 improve docs to better outline the tome creation process #519

Merged

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jan 30, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates docs around tome creation.

Which issue(s) this PR fixes:

Fixes #445

@hulto hulto linked an issue Jan 30, 2024 that may be closed by this pull request
Cictrone
Cictrone previously approved these changes Jan 30, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits

docs/_docs/user-guide/golem.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/golem.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/eldritch.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/golem.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/golem.md Show resolved Hide resolved
docs/_docs/user-guide/golem.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/golem.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/golem.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/golem.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c43bc7) 70.56% compared to head (23c8be7) 70.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   70.56%   70.56%           
=======================================
  Files         126      126           
  Lines        9587     9587           
=======================================
  Hits         6765     6765           
  Misses       2676     2676           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto merged commit e800bce into main Jan 30, 2024
8 checks passed
@hulto hulto deleted the 445-improve-docs-to-better-outline-the-tome-creation-process branch January 30, 2024 02:05
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
445 improve docs to better outline the tome creation process (#519)

* Docs updated.

* Docs updated.

* Resolve nits.

* Resolve feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve docs to better outline the tome creation process
3 participants